mardi 30 juin 2015

Freeing a multidimensional array when allocation fails


Say I allocate a two-dimensional array:

int main(void)
{
        long int **arr;
        int i;
        int j;

        arr = calloc(2, sizeof(long int *));
        if (!arr) {
                exit(EXIT_FAILURE);
        }

        for (i = 0; i < 2; i++) {
                arr[i] = calloc(10, sizeof(long int));
                if (!arr[i]) {
                        for (j = i; j > 0; j--) {
                                free(arr[j]);
                        }
                        free(arr);
                        exit(EXIT_FAILURE);
                }
        }
}

Should I include the free()-loop in the test condition if memory allocation fails

if (!arr[i]) {
        for (j = i; j > 0; j--) {
                free(arr[j]);
        }
        free(arr);
        exit(EXIT_FAILURE);
}

or is it usually enough to just exit() with failure when I don't want the program to move on?

if (!arr[i]) {
        exit(EXIT_FAILURE);
}


Aucun commentaire:

Enregistrer un commentaire